S3: added variable and new resources #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
storage/s3/main.tf
Outdated
| }) | ||
| } | ||
| } | ||
|
|
||
| resource "aws_s3_bucket" "kubeflow" { |
There was a problem hiding this comment.
why we use kubeflow for the bucket resource name?
There was a problem hiding this comment.
it looks like this module appeared from sak-kubeflow and the changes proposed to us. We need to make this module more universal so that it can be used in various situations, and not just in the kubeflow installation
There was a problem hiding this comment.
should I update this PR , or we can open other issue ?
There was a problem hiding this comment.
Just update this, please. Could you write an example in Readme.md how to quickly add this module into the main project?
There was a problem hiding this comment.
yes, I will write a readme as well
There was a problem hiding this comment.
Check now
garegintamrazyan07
force-pushed
the
feature/logging_cloudwatch_s3
branch
from
ab2a9a6 to
ceeae45
Compare
RustamGimadiev
approved these changes
Aug 17, 2021
RustamGimadiev
approved these changes
Aug 23, 2021
garegintamrazyan07
force-pushed
the
feature/logging_cloudwatch_s3
branch
from
9c4d233 to
a53020d
Compare
garegintamrazyan07
force-pushed
the
feature/logging_cloudwatch_s3
branch
from
a53020d to
df0ae14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #139